search

parse-community / ParseLiveQuery-Android

Parse LiveQuery client for Android.
Other
84 stars 32 forks source link

Deprecate this repo and integrate as module in Parse Android SDK #112

Open mtrezza opened 4 years ago

mtrezza commented 4 years ago

Issue

This repo depends on the Parse Android SDK and changes in there can break this repo. One example is the transition to the internalized bolts dependency https://github.com/parse-community/Parse-SDK-Android/issues/1036.

Solution

Deprecate this repo and integrate it as a module in the Parse Android SDK for better testing and dependency checking.

Jawnnypoo commented 4 years ago

Makes sense. Feel free to tackle this if you'd like.

mtrezza commented 4 years ago

I wonder if there was a reason why it has not been created as a module in the first place

Jawnnypoo commented 4 years ago

I don't think there was a reason other than the fact that different people were working on each project.

mmimeault commented 4 years ago

There was no specific reason. The iOS livequery was also in is own repo. And every other "feature/plugin/project" has its own repo in the parse-community org.

I think it's a question of opinion. Having a separate repo also allow the project to have its own "issue" and PR.

mtrezza commented 4 years ago

For separation we could just use labels. I think merging the few issues and PRs into the "main" SDK would actually give more oversight and prevent dependency issues.