search

parse-community / ParseLiveQuery-Android

Parse LiveQuery client for Android.
Other
84 stars 32 forks source link

Safely call close on the websocket client with synchronized calls #83

Closed mmimeault closed 6 years ago

mmimeault commented 6 years ago

https://github.com/parse-community/ParseLiveQuery-Android/issues/82

codecov[bot] commented 6 years ago

Codecov Report

Merging #83 into master will increase coverage by 3.76%. The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
+ Coverage      68.2%   71.96%   +3.76%     
- Complexity       82       84       +2     
============================================
  Files            11       11              
  Lines           368      371       +3     
  Branches         24       25       +1     
============================================
+ Hits            251      267      +16     
+ Misses          103       88      -15     
- Partials         14       16       +2
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/parse/ParseLiveQueryClientImpl.java 75.7% <ø> (ø) 56 <0> (ø) :arrow_down:
...ain/java/com/parse/OkHttp3SocketClientFactory.java 32.65% <25%> (+32.65%) 2 <0> (+2) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c39de0...d07f392. Read the comment docs.