search

parse-community / ParseLiveQuery-Android

Parse LiveQuery client for Android.
Other
84 stars 32 forks source link

Package refactor #88

Closed Jawnnypoo closed 6 years ago

Jawnnypoo commented 6 years ago
codecov[bot] commented 6 years ago

Codecov Report

Merging #88 into master will increase coverage by 0.39%. The diff coverage is 62.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
+ Coverage     71.96%   72.35%   +0.39%     
  Complexity       84       84              
============================================
  Files            11       11              
  Lines           371      369       -2     
  Branches         25       24       -1     
============================================
  Hits            267      267              
+ Misses           88       86       -2     
  Partials         16       16
Impacted Files Coverage Δ Complexity Δ
...n/java/com/parse/livequery/LiveQueryException.java 51.85% <ø> (ø) 2 <0> (?)
.../com/parse/livequery/SubscribeClientOperation.java 100% <ø> (ø) 2 <0> (?)
...rc/main/java/com/parse/livequery/Subscription.java 97.5% <ø> (ø) 17 <0> (?)
...java/com/parse/livequery/SubscriptionHandling.java 100% <ø> (ø) 0 <0> (?)
...java/com/parse/livequery/ParseLiveQueryClient.java 16.66% <ø> (ø) 0 <0> (?)
...om/parse/livequery/OkHttp3SocketClientFactory.java 32.65% <ø> (ø) 2 <0> (?)
...main/java/com/parse/livequery/WebSocketClient.java 100% <ø> (ø) 0 <0> (?)
...om/parse/livequery/UnsubscribeClientOperation.java 100% <100%> (ø) 2 <1> (?)
...main/java/com/parse/livequery/ClientOperation.java 100% <100%> (ø) 1 <1> (?)
...va/com/parse/livequery/ConnectClientOperation.java 100% <100%> (ø) 2 <1> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fb2aed...a6d6b58. Read the comment docs.

Jawnnypoo commented 6 years ago

@mmimeault Do you think you can review this for me?

Jawnnypoo commented 6 years ago

I see. Yeah, that makes sense about /* package */. The problem that I have seen with Parse-SDK-Android and the reason I have been removing it from there is that it completely throws off the JavaDocs and makes them unassociated from whatever method/class/field you are attempted to place them on.