parse-community / ParseLiveQuery-iOS-OSX

Parse LiveQuery Client for iOS/OS X.
https://parseplatform.org
Other
192 stars 133 forks source link

CocoaPods install doesn't compile #174

Closed drdaz closed 5 years ago

drdaz commented 6 years ago

I've made an example Xcode project (no code from me) where the Podfile is as follows:

# Uncomment the next line to define a global platform for your project
platform :ios, '11.0'

target 'PodsTest' do
  # Comment the next line if you're not using Swift and don't want to use dynamic frameworks
  use_frameworks!

  # Pods for PodsTest
  pod 'Parse'
  pod 'ParseLiveQuery'

  target 'PodsTestTests' do
    inherit! :search_paths
    # Pods for testing
  end

  target 'PodsTestUITests' do
    inherit! :search_paths
    # Pods for testing
  end

end

Running pod install creates a workspace which doesn't compile. It looks like the version of Bolts-Swift (1.3.0) linked to doesn't compile.

screenshot 2018-10-31 at 14 26 49

The code actually looks wrong to me:

screenshot 2018-10-31 at 14 28 56

I've tried forcing Bolts-Swift 1.4.0 into the mix by specifying so in the Podfile. Running pod update in this config yields a version 1.4.0 of the Parse iOS SDK and 2.2.3 of ParseLiveQuery. But the project compiles.

This doesn't seem quite right.

drdaz commented 6 years ago

PodsTest.zip

Here's the reproducer.

drdaz commented 6 years ago

Running a local repo with the current code, and bumping the Bolts-Swift dependency to 1.4.0 builds fine.

I haven't done any other testing yet.

drdaz commented 6 years ago

Here's a PR with the Podspec bump needed to fix this https://github.com/parse-community/ParseLiveQuery-iOS-OSX/pull/175

TomWFox commented 5 years ago

@drdaz Can this be closed now?

drdaz commented 5 years ago

@Tom-Fox1 I just updated to the current release in the project I use this in. It builds fine now. :)

Closing.