search

parse-community / ParseLiveQuery-iOS-OSX

Parse LiveQuery Client for iOS/OS X.
https://parseplatform.org
Other
192 stars 133 forks source link

Remove Bolts dependency and related helper files #223

Closed JoeSzymanski closed 4 years ago

JoeSzymanski commented 4 years ago

Based on discussions in https://github.com/parse-community/ParseLiveQuery-iOS-OSX/pull/222 around how to handle the Bolts dependency, it was determined the best course of action is probably to remove the Bolts dependency entirely, including the small set of helper code that made use of it.

Since the helper code is not complex and can easily be added by developers to their own projects, it was agreed that the removal of the Bolts dependency outweighed the benefits of having these helper methods available by default.

noobs2ninjas commented 4 years ago

Assuming this builds on travis. We are good to go.

JoeSzymanski commented 4 years ago

@noobs2ninjas It looks like something just got stuck i nthe one Cocoapods check. Is there a way to retrigger it to try again?

SWereszczynski commented 4 years ago

@noobs2ninjas Can you take a look at the Cocoapods step? I will appreciate your help.

noobs2ninjas commented 4 years ago

@JoeSzymanski restarted it and it seems like its passed now.

JoeSzymanski commented 4 years ago

I think someone can merge this now. I don't appear to have write access to do so.

JoeSzymanski commented 4 years ago

Would it be possible to get a release with this change? We'd like to move forward on the UIWebView removals, but are blocked on this at the moment.

noobs2ninjas commented 4 years ago

@JoeSzymanski the guys who manage Bolts are set to release a new release today fixing this exact issue. The moment that is done Parse and ParseLiveQuery will release with many changes and updated dependency versions.