parse-community / ParseLiveQuery-iOS-OSX

Parse LiveQuery Client for iOS/OS X.
https://parseplatform.org
Other
192 stars 133 forks source link

ci: fix CircleCI carthage timeout #260

Open mtrezza opened 2 years ago

mtrezza commented 2 years ago

New Pull Request Checklist

Issue Description

Related issue: https://github.com/parse-community/Parse-SDK-iOS-OSX/issues/1656

Approach

Increase timeout.

TODOs before merging

n/a

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this pull request!

mtrezza commented 2 years ago

@drdaz Strangely, here the timeout increase did not help, Carthage keep failing after ~16mins. Any idea?

drdaz commented 2 years ago

@mtrezza Not without seeing the test logs I'm afraid. It should be possible to run the target enabling SSH access, then you should be able to see how it's failing. The location of the logs is provided in the test failure console output.

drdaz commented 2 years ago

Oh now I see it 😅

Carthage seems to be importing v6.x of the Facebook SDK. The main repo uses 11.x (which is also pretty behind the times), and contains breaking changes.

mtrezza commented 2 years ago

Got it, do you think upgrading the FB SDK would be a time consuming PR?

drdaz commented 2 years ago

I feel like maybe another PR would be overkill. I'm pretty sure if you run carthage update on here and commit the changes to Cartfile.resolved (not all the stuff it checks out and builds), it'll work.

I tried to push those changes to this branch, but I'm getting an authentication error. Not sure if that's on my end or if I don't have push-powers here.

mtrezza commented 2 years ago

or if I don't have push-powers here

I think only the author and repo maintainers can push to a PR as the settings currently are.

mtrezza commented 2 years ago

carthage update failed for me on arm64 with:

Building universal frameworks with common architectures is not possible. The device and simulator slices for "Bolts" both build for: arm64
Rebuild with --use-xcframeworks to create an xcframework bundle instead.