search

parse-community / ParseUI-Android

ParseUI contains user interface libraries for building apps with the Parse Android SDK.
Other
592 stars 324 forks source link

trim username on login/signup #115

Closed jpilcher closed 8 years ago

jpilcher commented 8 years ago

When a user selects an auto-completed word, Android adds a space to the end. Less observant users may not notice this extra space and have trouble logging in after creating a username with a trailing space.

facebook-github-bot commented 8 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

facebook-github-bot commented 8 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

grantland commented 8 years ago

This might be confusing for users who do want a leading or tailing space in their username.

It seems to me that the best solution for this would be to turn off suggestions and autocompletes/capitalizations with android:inputType="text|textNoSuggestions" on sign up and login username EditTexts.

pablobaxter commented 8 years ago

@grantland That may still perform an AutoCorrect after finishing typing, possibly leaving a user with the same issue. I would suggest using android:inputType="textNoSuggestions|textVisiblePassword", as that will not bring up AutoComplete or AutoCorrect.

jpilcher commented 8 years ago

@grantland I was thinking about that as well. I guess it comes down to any restrictions Parse wants in usernames, which there appears to not be any. This potentially opens the question of whether or not there should be character restrictions in the username or if that level of flexibility outweighs giving the masses autocomplete.

grantland commented 8 years ago

@jpilcher that's definitely an interesting topic, however it's more of a backend topic rather than client side.

grantland commented 8 years ago

I'll be closing this for now, but we'd be more than happy to accept a PR that removes the autocomplete nature for username

facebook-github-bot commented 8 years ago

@jpilcher updated the pull request.