search

parse-community / ParseUI-Android

ParseUI contains user interface libraries for building apps with the Parse Android SDK.
Other
592 stars 323 forks source link

Intent data is not passed along to target activity #15

Closed vishalpatel closed 8 years ago

vishalpatel commented 10 years ago

I found that in ParseLoginDispatchActivity we drop the intent args passed by requestor. I breaks some workflows where the requestor has set args for profile activity to show user profile by arg (say "email") and then because of the loginDispatchActivity the args are lost.

vishalpatel commented 10 years ago

I don't have access to push a branch and create pull request. But here is a patch https://gist.github.com/vishalpatel/c5e20b3a5895db576118

stanleyw commented 9 years ago

Thanks for making the patch! Please see https://github.com/ParsePlatform/ParseUI-Android/blob/master/CONTRIBUTING.md for instructions on making a pull request for your patch. That way we make sure you get proper credit for your work.

The patch looks good to me. The only minor comment I had was for style consistency with the rest of the repo, please use braces in the if statement even though it's single line and 2-space indent.

ghost commented 9 years ago

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.