search

parse-community / ParseUI-Android

ParseUI contains user interface libraries for building apps with the Parse Android SDK.
Other
592 stars 323 forks source link

Fix User Signup w/ custom User Subclass #89

Closed netizen01 closed 8 years ago

netizen01 commented 8 years ago

Signup would crash if a subclass of ParseUser was being used. Instead of instantiating ParseUser directly, find the correct subclass from the ParseObject subclass registration map.

facebook-github-bot commented 8 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

netizen01 commented 8 years ago

Signed the CLA.

facebook-github-bot commented 8 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

netizen01 commented 8 years ago

Any ETA on this integration?

wangmengyan95 commented 8 years ago

LGTM. Ship it. Thank you @netizen01.