search

parse-community / blog

Parse Community Blog
http://blog.parseplatform.org
Apache License 2.0
18 stars 20 forks source link

tag links are broken #12

Closed acinader closed 5 years ago

acinader commented 6 years ago

the tags that aren't a top level like All or Announcement 404 when you click on them. example: https://blog.parseplatform.org/blog/categories/javascript

TomWFox commented 5 years ago

I noticed this too. I'm wondering what behaviour we want here:

  1. The tags are shown but don't have links - so at least they won't 404 (for the ones that aren't top level)
  2. we remove the tags
  3. We add them as new categories but perhaps not top level as there would be too many

Or something else? - I could look at doing a PR for this but think we should work out the desired solution first

TomWFox commented 5 years ago

I just did a little test by adding a new category for javascript and that fixes the link without automatically adding the tag to the top level navigation so doing option 3 is relatively easy.

I suppose ideally new categories would be created automatically, but I don't mind creating them manually for the time being so the links aren't broken.

TomWFox commented 5 years ago

I've made a branch on my fork which standardises the categories and fixes the broken tags - I can PR this as a quick fix

TomWFox commented 5 years ago

Done #14

TomWFox commented 5 years ago

Concluded for all historic posts in #17