Documentation for deleting files

parse-community / docs

Parse Platform docs

https://docs.parseplatform.org

Other

313 stars 517 forks source link

Closed dblythy closed 3 years ago

dblythy commented 3 years ago

Closes #726

mtrezza commented 3 years ago

@TomWFox I just merged this and in the moment I thought you may wanna look over it, apologies if that was off protocol.

mtrezza commented 3 years ago

My meticulousness kicked in and I opened https://github.com/parse-community/docs/pull/791 to do some minor corrections:

Clarified wording; it could be understood that for Parse Server <4.2.0 it is not possible to delete a file using Cloud Code, which is incorrect.
Simplified example code; it is not necessary to use a beforeDelete hook the example; given the beforeDelete name, one could assume that it is somehow related to the basic functionality of deleting a file, which it is not.

dblythy commented 3 years ago

I'm glad you accidentally merged this because you've done a better job than I did haha. Thanks for your hard work for the community!

mtrezza commented 3 years ago

I only realized these subtleties after merging, otherwise I'd have suggested the changes to you. Thanks for opening this PR!

TomWFox commented 3 years ago

@mtrezza Ideally I like to look at all the docs PRs before merging but its not a big deal :)

mtrezza commented 3 years ago

I though so, next time ;)