search

parse-community / docs

Parse Platform docs
https://docs.parseplatform.org
Other
313 stars 518 forks source link

Need session activation from Parse #830

Closed FandryNoutah closed 3 years ago

FandryNoutah commented 3 years ago

After logging in with parseUser, it can be fine if you start session automatically and developers don't need to call PHP session_start() function, or define into the documentation the full use of the session, thanks.

mtrezza commented 3 years ago

@TomWFox Did you request a technical review? This change has errors in style and typos.

TomWFox commented 3 years ago

Hmm, perhaps technical and style. A lack of technical understanding on my part (never written any php!) also leaves me unsure of the best style here!

mtrezza commented 3 years ago

@dplewis As I understand it, the developer needs to call session_start() to make PHP read the session into the $_SESSION superglobal, which then becomes available to Parse when initializing the SDK to resume the session. Do you know why we let the developer do this manually in the PHP SDK instead of doing this automatically? For comparison, how is that handled in the JS SDK?

dplewis commented 3 years ago

@mtrezza I believe that calling session_start() multiple times will result in an error being thrown which is probably why we don't include it in the SDK.

If a developer tries to use persistant storage an error is called

'PHP session_start() must be called first.'

If a developer only wants to query and such without persistant storage then calling session_start() in the SDK will be a performance hit.

A note in the docs is fine, it should have been added a while ago, see https://github.com/parse-community/parse-php-sdk/issues/41

mtrezza commented 3 years ago

Thanks for that insight, and that you even found https://github.com/parse-community/parse-php-sdk/issues/41. Note is in the docs. We should be good now.