Endpoint `loginAs` is falsely documented to require GET request

aclec commented 2 years ago

New Issue Checklist

[X] I am not disclosing a vulnerability.
[X] I am not just asking a question.
[X] I have searched through existing issues.
[X] I can reproduce the issue with the latest version of Parse Server.

Issue Description

I'm trying to log by REST API with /loginAs and the answer is "Cannot GET /parse/loginAs". But it's working with POST request. Is it just an error in the documentation ?

Steps to reproduce

Make GET request on /loginAs like it's write on documentation.

Environment

Server

Parse Server version: 5.2.4
Operating system: Linux
Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): Local

Database

System (MongoDB or Postgres): MongoDB
Database version: 5
Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): Local

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this issue!

❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.

mtrezza commented 2 years ago

A log-in method always has to be a POST request, because it's not idempotent. If you look at the code, it's correctly implemented as a POST route:

https://github.com/parse-community/parse-server/blob/4c29d4d23b67e4abaf25803fe71cae47ce1b5957/src/Routers/UsersRouter.js#L481-L483

Where in the docs did you read that a GET request should be used?

aclec commented 2 years ago

@mtrezza on the Rest api doc: https://docs.parseplatform.org/rest/guide/#user-impersonation

mtrezza commented 2 years ago

I transferred the issue to the docs repo. Would you mind opening a PR to correct the docs?

aclec commented 2 years ago

Sure, I'll do that

mtrezza commented 2 years ago

Closing via #897

parse-community / docs