Closed dplewis closed 11 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
a25c835
) 93.53% compared to head (9370b2f
) 93.53%. Report is 1 commits behind head on master.:exclamation: Current head 9370b2f differs from pull request most recent head e831e6f. Consider uploading reports for the commit e831e6f to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🎉 This change has been released in version 6.0.0
https://github.com/parse-community/node-apn/blob/master/package.json#L68 package.json engines was still left out :)
@wojtekmaj Thanks, you are right, do you want to open a quick PR?
@mtrezza Done. Also, repository settings must be updated to require new tests and unrequire removed ones, but that needs to be done by the maintainer :)
Thanks, done in https://github.com/parse-community/node-apn/pull/138
https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#nodejs
There was a fix in the http2 module to correctly handle errors. Before we had to parse the error in the
end
event now its handled onerror
emitter on client requests.Closes: #132
This PR is referencing #131, which has now been closed.