search

parse-community / node-apn

Apple Push Notification module for Node.js
Other
172 stars 61 forks source link

I miss the localised subtitle properties `subtitle-loc-key` and `subtitle-loc-args` because you're using old Apple documentation #139

Closed funnel20 closed 1 week ago

funnel20 commented 8 months ago

Thanks for this great lib.

The detailed apn.Notification documentation refers to the Apple payload documentation at https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/CreatingtheNotificationPayload.html

This link is outdated, the modern docu can be found at https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/generating_a_remote_notification In particular Table 2 is important, as it shows a set of new keys which is not present in your Convenience Setters. Among them the subtitle and it's localised variants; subtitle-loc-key and subtitle-loc-args.

Would it be possible to add these and other missing ones and update your documentation?

parse-github-assistant[bot] commented 8 months ago

Thanks for opening this issue!

parseplatformorg commented 1 week ago

🎉 This change has been released in version 6.2.0

funnel20 commented 1 week ago

@mtrezza Thank you very much

mtrezza commented 1 week ago

(Forwarding your thanks to @cbaker6 who provided the PR)

funnel20 commented 6 days ago

Version 6.2.0 successful in production after using the 2 new fields ✅ Here is the server log:

Sending 11 notifications...
 · Completed sending 11 notifications in 0.66 seconds (17 messages/second)
 · 11 sent, 0 failed