search

parse-community / parse-dashboard

A dashboard for managing Parse Server
https://parseplatform.org
Other
3.74k stars 1.39k forks source link

fix: File uploading status not updating in data browser #2422

Closed patelmilanun closed 1 year ago

patelmilanun commented 1 year ago

New Pull Request Checklist

Issue Description

there was a problem of status change when u do upload a file. The problem was that even after the file is uploaded there is no way the user is getting notified of it as the field will show uploading.. even though the upload is completed.

Closes: #2274

Approach

So the issue is that we are saving the row before saving of file gets completed and thus we are not able to identify that the change has occurred. This PR resolve it by resolving the pending file upload promise if its there and than re-render the cell.

TODOs before merging

None

parse-github-assistant[bot] commented 1 year ago

I will reformat the title to use the proper commit message syntax.

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

uffizzi-cloud[bot] commented 1 year ago

Uffizzi Ephemeral Environment deployment-22315

:watch: Updated Apr 14, 2023, 18:46 UTC

:cloud: https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2422

:page_facing_up: View Application Logs etc.

What is Uffizzi? Learn more

patelmilanun commented 1 year ago

How one can see the preview build which uses mongodb as the given preview url is using postgreSQL

mtrezza commented 1 year ago

What do you mean

patelmilanun commented 1 year ago

So if I open the preview link generated with Uffizzi, we are not able to do file upload as it is integrated with mongoDB only I think, and in order to take a look at if my changes fixed the issue or not the preview link should use mongoDB. If u look at the logs for the build you can see we are using PostgreSQL and not the mongoDB. This problem is specific to mongoDB.

So for case like this where we have to only see our changes using mongoDB as our database is it possible?

mtrezza commented 1 year ago

Got it, the current set up is limited to what it is. We could look into expanding this, but that's a separate issue we'd need to explore. For now we'd just test this locally and merge if we can verify the issue is fixed.

parseplatformorg commented 1 year ago

🎉 This change has been released in version 5.2.0-alpha.7

parseplatformorg commented 1 year ago

🎉 This change has been released in version 5.2.0-beta.2

parseplatformorg commented 1 year ago

🎉 This change has been released in version 5.2.0