parse-community / parse-dashboard

A dashboard for managing Parse Server
https://parseplatform.org
Other
3.74k stars 1.39k forks source link

fix: File extension is hidden in file field when editing object in modal dialog in data browser #2472

Closed AshishBarvaliya closed 1 year ago

AshishBarvaliya commented 1 year ago

Closes: #2470

Approach

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

uffizzi-cloud[bot] commented 1 year ago

Uffizzi Ephemeral Environment deployment-29165

:watch: Updated Jun 22, 2023, 01:12 UTC

:cloud: https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2472

:page_facing_up: View Application Logs etc.

What is Uffizzi? Learn more

uffizzi-cloud[bot] commented 1 year ago

Uffizzi Ephemeral Environment deployment-29341

:watch: Updated Jun 23, 2023, 23:36 UTC

:cloud: https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2472

:page_facing_up: View Application Logs etc.

What is Uffizzi? Learn more

mtrezza commented 1 year ago

Could you add a screen recording of what this PR fixes?

AshishBarvaliya commented 1 year ago

Rather than implementing changes to the common pill component to adjust the file cell styles in EditRowDialog, I have devised a new style class. This modification enhances the readability of file names along with their extensions.

Before changes -

Screenshot 2023-06-24 at 1 27 33 PM

After changes -

Screenshot 2023-06-24 at 1 25 42 PM
mtrezza commented 1 year ago

Which parts of the UI does this affect? Is this the "Add row with modal" dialog?

AshishBarvaliya commented 1 year ago

yes

uffizzi-cloud[bot] commented 1 year ago

Uffizzi Ephemeral Environment deployment-29354

:watch: Updated Jun 24, 2023, 21:01 UTC

:cloud: https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2472

:page_facing_up: View Application Logs etc.

What is Uffizzi? Learn more

mtrezza commented 1 year ago

I only see en empty field when uploading a file with modal:

image

Tried in preview and locally.

AshishBarvaliya commented 1 year ago

This open PR fixes that issue : #2471 (issue: #2418 )

mtrezza commented 1 year ago

So we need to merge #2471 first, then this PR?

AshishBarvaliya commented 1 year ago

Save the object(row) first, and then you'll be able to view the uploaded file.

mtrezza commented 1 year ago

Then I still don't fully understand what this PR fixes. Could you please upload a screen recording (not screenshot) of the bug vs. fixed?

AshishBarvaliya commented 1 year ago

Before: CPT2306262126-1181x641

After: CPT2306262127-1135x635

It's essentially a minor style fix where previously the file was displayed as '666162,' but after the changes, it now appears as '666162.png'.

mtrezza commented 1 year ago

Got it, that is when editing an existing row, I was able to duplicate that, thanks for the videos.

parseplatformorg commented 1 year ago

🎉 This change has been released in version 5.2.0-alpha.26

parseplatformorg commented 1 year ago

🎉 This change has been released in version 5.3.0-beta.1

parseplatformorg commented 1 year ago

🎉 This change has been released in version 5.3.0-alpha.1

parseplatformorg commented 11 months ago

🎉 This change has been released in version 5.3.0