fix: Crash after setting filter using context menu and opening filters panel

parse-community / parse-dashboard

A dashboard for managing Parse Server

https://parseplatform.org

Other

3.74k stars 1.38k forks source link

fix: Crash after setting filter using context menu and opening filters panel #2579

Closed 404-html closed 1 month ago

404-html commented 1 month ago

New Pull Request Checklist

[x] I am not disclosing a vulnerability.
[x] I am creating this PR in reference to an issue.

Issue Description

Fixes: https://github.com/parse-community/parse-dashboard/issues/2578

Approach

Seems that filter now have additional property: class. When setting filter using context menu this property was not provided. This was causing an issue when binding filters. I did following:

Setting 'class' on filter when using context menu filters
In addition, when parsing filters from query strings, setting class if it's missing; this should provide some backward compatibility

TODOs before merging

parse-github-assistant[bot] commented 1 month ago

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.