Add ParsePolygon Type and polygonContains query

[dplewis]

https://github.com/parse-community/parse-server/pull/3944

Added ParsePolygon Type created from Array of Coordinates or ParseGeoPoints Added polygonContains to query.

I'm using PHP as a base for updating the other sdks.

Let me know if any more tests are needed or additional functionality.

[dplewis]

There's an added benefit of mixing and matching points and geopoints

[montymxb]

@dplewis looks like #3944 is pretty much good to go! Once that gets merged in we can move along with this.

[flovilmart]

now it's merged!

[montymxb]

Whoops looks like the latest branch only just finished releasing. I'll rerun these once more to get that change.

[montymxb]

@dplewis tests look good! What's causing this to fail out is the phpdoc enforcing that was added not too long ago. You can verify that phpdoc looks good via npm run document-check locally to verify this.

In this case it seems you need a summary for ParsePolygon.php. You can check this against the other src files, like the top of ParseACL.php for example.

<?php
/**
 * Class ParseACL | Parse/ParseACL.php
 */

[dplewis]

@montymxb I figured something like that would happen. I fixed the summary documentation.

[montymxb]

@dplewis thanks for the changes!

Looks like phpdoc is running on the contents of vendor. I'm seeing this on #334 as well, last night seemed to be good though. I'll see if I can't correct this and then we can retry here.

[dplewis]

@montymxb no problem

[montymxb]

Looks like updating composer dependencies allowed me to replicate this locally. It would appear a package has been updated between yesterday and today that is tripping this :/ . I'll keep digging and see how we can patch this up.

[montymxb]

@dplewis the culprit is jms/serializer, referenced internally by phpdoc.

It was updated to 1.8.0 earlier this morning. Locally specifying the prior 1.7.1 corrects this issue like so in composer.json under require-dev:

"jms/serializer": "1.7.1"

I'll put up a separate PR to fix this and merge it in real quick, then we can go from there.

[codecov[bot]]

Codecov Report

Merging #327 into master will increase coverage by 0.74%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   98.04%   98.78%   +0.74%     
==========================================
  Files          35       35              
  Lines        2708     2727      +19     
==========================================
+ Hits         2655     2694      +39     
+ Misses         53       33      -20

Impacted Files	Coverage Δ
src/Parse/ParseRelation.php	100% <ø> (ø)	:arrow_up:
src/Parse/ParseSession.php	100% <ø> (ø)	:arrow_up:
src/Parse/ParseAggregateException.php	100% <ø> (ø)	:arrow_up:
src/Parse/Internal/SetOperation.php	100% <ø> (ø)	:arrow_up:
src/Parse/Internal/AddUniqueOperation.php	100% <ø> (ø)	:arrow_up:
src/Parse/ParseACL.php	100% <ø> (ø)	:arrow_up:
src/Parse/ParseInstallation.php	100% <ø> (ø)	:arrow_up:
src/Parse/ParseSchema.php	97.07% <ø> (ø)	:arrow_up:
src/Parse/ParseSessionStorage.php	100% <ø> (ø)	:arrow_up:
src/Parse/Internal/AddOperation.php	100% <ø> (ø)	:arrow_up:
... and 26 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20dd7a5...699f9ab. Read the comment docs.

[montymxb]

Finally, alright I'll give this just another quick check and we should be good to go!

[montymxb]

@dplewis nearly 3 weeks later but it's finally in 👍 . Looks like you can attend to those other sdks as needed now.

Thanks again for adding in this functionality!

[montymxb]

Since each update to the master is now automatically deployed to gh-pages you can take a look at your api ref for ParsePolygon here. In addition there's a pretty cool class inheritance diagram you can check out as well.

[dplewis]

That diagram looks pretty cool