search

parse-community / parse-php-sdk

The PHP SDK for Parse Platform
https://parseplatform.org/
Other
811 stars 346 forks source link

Remove Default API #332

Closed montymxb closed 7 years ago

montymxb commented 7 years ago

Currently the default url is https://api.parse.com/ and the default mount path if /1. Given that api.parse.com is no longer active and will only respond to requests with the message Parse.com has shutdown - https://parseplatform.github.io/ it is probably time to clear these defaults.

Additionally it would appear that there is no valid certificate for this api. Attempting to connect to the original service from this sdk will throw a ParseException containing the following message:

SSL certificate problem: Invalid certificate chain

This can be further verified through additional means (curl through the terminal, browser, etc).

This PR removes the default server url and mount path variables, and adds verification in ParseClient::_request that both the server url and the mount path have been initialized before proceeding. Tests have been added to account for both cases as well.

::EDIT::

This also contains a couple typo changes where Parse::initialize was stated in an exception message where it should be ParseClient::initialize. The relevant test cases were updated as well.

codecov[bot] commented 7 years ago

Codecov Report

Merging #332 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   98.76%   98.77%   +<.01%     
==========================================
  Files          34       34              
  Lines        2682     2696      +14     
==========================================
+ Hits         2649     2663      +14     
  Misses         33       33
Impacted Files Coverage Δ
src/Parse/ParseClient.php 99% <100%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 592e376...2dd40df. Read the comment docs.

montymxb commented 7 years ago

Cool 😎. I think I'll open up some PRs / issues on the other sdks as well. See if we can't get those old defaults scrubbed out.