Add Indexes via Schema

[dplewis]

Pending: https://github.com/parse-community/parse-server/pull/4240

[montymxb]

Cool! Same deal here as with the aggregate queries. Once the server side functionality is in I'll go over this.

[dplewis]

@montymxb I added documentation and fixed the tests. The test weren't working locally at first until I updated my version of node from 6.10 to 9.2. I know the latest version of parse-server requires a minimum node version 6.11.4. Can you have a look into travis?

[montymxb]

Sure thing @dplewis , I'll see what's going on here...

[montymxb]

Took a look locally, seems to be just an outdated version of parse-server in cache. Dumped it and rerunning now. I did see one failure which looks to be consistent and is beyond this PR, probably due to a change in the server. We'll see if it reproduces when these run through.

[dplewis]

Are you talking about the testBadSchemaDelete or testCheckBadServer tests? I got those failing when running locally.

[montymxb]

Nope, schema tests look good actually. This is what I saw locally.

1) Parse\Test\ParseFileTest::testParseFileTypes
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'application/octet-stream'
+'null'

Curious if it's just a local issue or if it will repeat up here. If so I'll need to take a further look.

[dplewis]

@montymxb I got that as well

[montymxb]

Looks like there's still further issues starting up the test server. I'll have to look at this tomorrow when I have some time.

[montymxb]

@dplewis master is good now, you can merge against it when you have a moment.

[codecov[bot]]

Codecov Report

Merging #357 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   99.01%   99.02%   +<.01%     
==========================================
  Files          38       38              
  Lines        3562     3579      +17     
==========================================
+ Hits         3527     3544      +17     
  Misses         35       35

Impacted Files	Coverage Δ
src/Parse/ParseSchema.php	97.3% <100%> (+0.22%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8fdecc...c3531e7. Read the comment docs.

[dplewis]

@montymxb thanks for fixing the tests

[montymxb]

Sweet we're ready for 1.4.0. I'll craft a release later tonight.