search

parse-community / parse-php-sdk

The PHP SDK for Parse Platform
https://parseplatform.org/
Other
811 stars 346 forks source link

Adds Fix for Changed Push Status Life Cycle #393

Closed montymxb closed 6 years ago

montymxb commented 6 years ago

This adds a small fix to our test suite that was affected by a change to the push status life cycle. Originally we could create a dummy set of pushes and expect it to be marked as 'failed'. That has since changed to be marked as 'succeeded'. In terms of functionality nothing has really changed, but the reported push statuses didn't match up with what we were expecting.

The adjustment to the tests should still pass with servers using the old push status life cycle.

codecov[bot] commented 6 years ago

Codecov Report

Merging #393 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files          38       38           
  Lines        3116     3116           
=======================================
  Hits         3084     3084           
  Misses         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cef7394...ea7a6bc. Read the comment docs.

parse-github-assistant[bot] commented 2 years ago

The label type:feature cannot be used here.