search

parse-community / parse-php-sdk

The PHP SDK for Parse Platform
https://parseplatform.org/
Other
811 stars 346 forks source link

When creating a ParseUser instance, be sure to use static to get registered subclasses. #394

Closed acinader closed 6 years ago

acinader commented 6 years ago

see: #84

This just eliminates two other places where ParseUser is called instead of using the subclass's static constructor.

acinader commented 6 years ago

@montymxb, unfortunately, unit tests are failing on master due to an npm install issue.....

montymxb commented 6 years ago

Gotcha, I'll look into that today. Other than the CI issue the changes look good 👍 , thanks for catching those. I'll see if I can resolve the CI thing before we take this in.

acinader commented 6 years ago

@montymxb do you want me to merge this?

montymxb commented 6 years ago

@acinader Yeah that's fine. Still need to resolve the CI issue, but we can do that separately.