Closed acinader closed 5 years ago
LGTM!
Sent with GitHawk
Can you check that authData->anonymous == null?
Your current test only shows that all authData is gone.
@dplewis I don't understand.
I set it to null so it'll be removed, so there's no authData to check.
@acinader nvm, I didn't know this was happening on the back end.
https://github.com/parse-community/parse-server/blob/master/src/RestWrite.js#L1519
Looks good to me!
Merging #429 into master will increase coverage by
<.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 98.92% 98.92% +<.01%
==========================================
Files 38 38
Lines 3152 3158 +6
==========================================
+ Hits 3118 3124 +6
Misses 34 34
Impacted Files | Coverage Δ | |
---|---|---|
src/Parse/ParseUser.php | 98.36% <100%> (+0.04%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 97d9455...efb120d. Read the comment docs.
Has the added benefit of working with current versions of mongo :).
I copied this from https://github.com/parse-community/parse-server/blob/master/spec/ParseUser.spec.js#L2640
see: https://github.com/parse-community/parse-php-sdk/pull/427#issuecomment-458722990