codecov[bot] commented 5 years ago

Codecov Report

Merging #447 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #447   +/-   ##
=========================================
  Coverage     96.98%   96.98%           
  Complexity     1058     1058           
=========================================
  Files            39       39           
  Lines          2950     2950           
=========================================
  Hits           2861     2861           
  Misses           89       89

Impacted Files	Coverage Δ	Complexity Δ
src/Parse/ParseClient.php	`92.95% <ø> (ø)`	`97 <0> (ø)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 942dcc2...1704e57. Read the comment docs.

dplewis commented 5 years ago

@acinader i have one more PR to add to this. Is releasing the same as the other SDKs? Do you need to change the deployment keys?

acinader commented 5 years ago

Hi Diamond,

Yes, it looks like $GITHUB_TOKEN is now missing so the sdk docs will fail to post to gh-pages.

I've been using travis encrypt instead.

The reason being that:

a) it's what I use for my job b) since it is under git, we can see who committed and when, and any changes are visible in history (even if they're encrypted so you can't read em)

is that ok with you? do you have permissions to travis encrypt in that repo? If not, let's that setup for you?

dplewis commented 5 years ago

That’s perfectly fine. I’ll leave it up to you. I’ve seen you change them it in other SDKs.

acinader commented 5 years ago

looks like i've been publishing it i think. i'll look into how to script it with travis.

acinader commented 5 years ago

@dplewis is this waiting on me?

dplewis commented 5 years ago

Yes sir

parse-community / parse-php-sdk

⚡️ Release 1.6.0 #447

Codecov Report