parse-community / parse-php-sdk

The PHP SDK for Parse Platform
https://parseplatform.org/
Other
811 stars 346 forks source link

Fix PHPUnit Risky Tests #449

Closed dplewis closed 5 years ago

dplewis commented 5 years ago

Some tests were missing assert

Screen Shot 2019-07-23 at 4 16 52 PM
codecov[bot] commented 5 years ago

Codecov Report

Merging #449 into master will increase coverage by 1.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #449      +/-   ##
==========================================
+ Coverage     96.98%    98%   +1.01%     
  Complexity     1058   1058              
==========================================
  Files            39     39              
  Lines          2950   2950              
==========================================
+ Hits           2861   2891      +30     
+ Misses           89     59      -30
Impacted Files Coverage Δ Complexity Δ
src/Parse/ParseObject.php 98.1% <0%> (+0.17%) 224% <0%> (ø) :arrow_down:
src/Parse/ParseUser.php 98.31% <0%> (+1.26%) 67% <0%> (ø) :arrow_down:
src/Parse/Internal/ParseRelationOperation.php 100% <0%> (+1.66%) 43% <0%> (ø) :arrow_down:
src/Parse/ParseClient.php 95.59% <0%> (+2.64%) 97% <0%> (ø) :arrow_down:
src/Parse/ParseACL.php 100% <0%> (+5.83%) 61% <0%> (ø) :arrow_down:
src/Parse/ParseSessionStorage.php 100% <0%> (+9.09%) 11% <0%> (ø) :arrow_down:
src/Parse/ParseMemoryStorage.php 100% <0%> (+12.5%) 8% <0%> (ø) :arrow_down:
src/Parse/ParsePush.php 100% <0%> (+14.28%) 13% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 942dcc2...33c6ca5. Read the comment docs.