search

parse-community / parse-php-sdk

The PHP SDK for Parse Platform
https://parseplatform.org/
Other
812 stars 346 forks source link

Deprecation issue fixed in ParseUser class #472

Closed majidkarimizadeh closed 3 years ago

majidkarimizadeh commented 3 years ago

Set default value for argument in order to resolve deprecation issue.

dplewis commented 3 years ago

Can you take a screen shot of the deprecation issue? Also I realized that that we no longer use Travis CI. I can migrate to Github Action and fix the build.

codecov[bot] commented 3 years ago

Codecov Report

Merging #472 (dfe388b) into master (dffe023) will increase coverage by 0.10%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #472      +/-   ##
============================================
+ Coverage     97.97%   98.07%   +0.10%     
- Complexity     1062     1063       +1     
============================================
  Files            39       39              
  Lines          2960     2964       +4     
============================================
+ Hits           2900     2907       +7     
+ Misses           60       57       -3
Impacted Files Coverage Δ
src/Parse/ParseUser.php 98.31% <ø> (ø)
src/Parse/ParseQuery.php 99.75% <0.00%> (+<0.01%) :arrow_up:
src/Parse/ParseObject.php 97.97% <0.00%> (+<0.01%) :arrow_up:
src/Parse/ParseSchema.php 98.50% <0.00%> (+1.49%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dffe023...dfe388b. Read the comment docs.

majidkarimizadeh commented 3 years ago

Hi @dplewis, Thanks for your reply. Changes have done. Thanks.

dplewis commented 3 years ago

@majidkarimizadeh Did you mean to close this?