parse-community / parse-php-sdk

The PHP SDK for Parse Platform
https://parseplatform.org/
Other
812 stars 346 forks source link

ci: Run test suite against `ParseStream` #509

Closed dplewis closed 1 year ago

dplewis commented 1 year ago

New Pull Request Checklist

Issue Description

The test suite runs against cURL, this PR adds stream context tests to the CI. We should support both http clients.

// set curl http client (default if none set)
ParseClient::setHttpClient(new ParseCurlHttpClient());

// set stream http client
// ** requires 'allow_url_fopen' to be enabled in php.ini **
ParseClient::setHttpClient(new ParseStreamHttpClient());

TODOs before merging

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12 :tada:

Comparison is base (d46107e) 98.48% compared to head (5062f70) 98.60%.

:exclamation: Current head 5062f70 differs from pull request most recent head 9853c44. Consider uploading reports for the commit 9853c44 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #509 +/- ## ============================================ + Coverage 98.48% 98.60% +0.12% - Complexity 1060 1062 +2 ============================================ Files 38 38 Lines 3225 3229 +4 ============================================ + Hits 3176 3184 +8 + Misses 49 45 -4 ``` | [Impacted Files](https://app.codecov.io/gh/parse-community/parse-php-sdk/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community) | Coverage Δ | | |---|---|---| | [src/Parse/HttpClients/ParseStream.php](https://app.codecov.io/gh/parse-community/parse-php-sdk/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-c3JjL1BhcnNlL0h0dHBDbGllbnRzL1BhcnNlU3RyZWFtLnBocA==) | `100.00% <100.00%> (+22.22%)` | :arrow_up: | | [src/Parse/ParseClient.php](https://app.codecov.io/gh/parse-community/parse-php-sdk/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-c3JjL1BhcnNlL1BhcnNlQ2xpZW50LnBocA==) | `95.23% <100.00%> (-0.44%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/parse-community/parse-php-sdk/pull/509/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

parseplatformorg commented 1 year ago

🎉 This change has been released in version 2.2.0