parse-community / parse-server-api-mail-adapter

API Mail Adapter for Parse Server
MIT License
27 stars 17 forks source link

New release from parse community version #95

Closed valerycolong closed 1 week ago

valerycolong commented 1 week ago

New Pull Request Checklist

Issue Description

Related issue: FILL_THIS_OUT

Approach

TODOs before merging

parse-github-assistant[bot] commented 1 week ago

The branch release can only be set as base branch by members of @parse-community/core-maintainers.

Pull requests are usually opened against the default branch release, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.

parse-github-assistant[bot] commented 1 week ago

Thanks for opening this pull request!

parse-github-assistant[bot] commented 1 week ago

The branch release can only be set as base branch by members of @parse-community/core-maintainers.

Pull requests are usually opened against the default branch release, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.

parse-github-assistant[bot] commented 1 week ago

The branch release can only be set as base branch by members of @parse-community/core-maintainers.

Pull requests are usually opened against the default branch release, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.

parse-github-assistant[bot] commented 1 week ago

The branch release can only be set as base branch by members of @parse-community/core-maintainers.

Pull requests are usually opened against the default branch release, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.

parse-github-assistant[bot] commented 1 week ago

The branch release can only be set as base branch by members of @parse-community/core-maintainers.

Pull requests are usually opened against the default branch release, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.

mtrezza commented 1 week ago

@valerycolong This mail adapter has been designed specifically to allow adding any 3rd party mail providers like Sendgrid. This should not require any changes in the adapter code, other than in the file src/ApiPayloadConverter.js. With the changes in this PR we cannot accept to merge it. If you want to refactor and only make the changes in the file mentioned earlier (and the README for documentation), then we'll be happy to review. The benefit of submitting a PR for Sendgrid to our repository would be that you don't have to maintain a custom fork, which, given the vast changes in this PR, could become quite complex quite quickly when we'll make changes in the base repository in the future.