Closed valerycolong closed 1 month ago
The branch release
can only be set as base branch by members of @parse-community/core-maintainers
.
Pull requests are usually opened against the default branch release
, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.
FILL_THIS_OUT
, otherwise your pull request will be closed. If a field does not apply to the pull request, fill in n/a
.The branch release
can only be set as base branch by members of @parse-community/core-maintainers
.
Pull requests are usually opened against the default branch release
, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.
The branch release
can only be set as base branch by members of @parse-community/core-maintainers
.
Pull requests are usually opened against the default branch release
, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.
The branch release
can only be set as base branch by members of @parse-community/core-maintainers
.
Pull requests are usually opened against the default branch release
, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.
The branch release
can only be set as base branch by members of @parse-community/core-maintainers
.
Pull requests are usually opened against the default branch release
, which is the working branch. Different repositories may have base branches with different names. If you are sure you need to open this pull request against a different branch, please ask someone from the team mentioned above.
@valerycolong This mail adapter has been designed specifically to allow adding any 3rd party mail providers like Sendgrid. This should not require any changes in the adapter code, other than in the file src/ApiPayloadConverter.js
. With the changes in this PR we cannot accept to merge it. If you want to refactor and only make the changes in the file mentioned earlier (and the README for documentation), then we'll be happy to review. The benefit of submitting a PR for Sendgrid to our repository would be that you don't have to maintain a custom fork, which, given the vast changes in this PR, could become quite complex quite quickly when we'll make changes in the base repository in the future.
New Pull Request Checklist
Issue Description
Related issue: FILL_THIS_OUT
Approach
TODOs before merging