Closed flovilmart closed 8 years ago
87.50%
Merging #10 into master will increase coverage by +0.48% as of
f6a1ce1
@@ master #10 diff @@
=====================================
Files 5 5
Stmts 239 248 +9
Branches 38 40 +2
Methods 0 0
=====================================
+ Hit 208 217 +9
Partial 1 1
Missed 30 30
Review entire Coverage Diff as of
f6a1ce1
Powered by Codecov. Updated on successful CI builds.
@@ master #10 diff @@
==========================================
Files 5 5
Lines 261 270 +9
Methods 28 30 +2
Messages 0 0
Branches 45 46 +1
==========================================
+ Hits 230 239 +9
Misses 31 31
Partials 0 0
Powered by Codecov. Last updated by d789ef6...7c0235d
@drew-gross let me know what you think as it really changes the game
Seems fine to me but I'm not really the best person to review push related code. @bnham or @nlutsenko would probably be better.
this pull request it's somewhat forgotten :)
@darkkiss thats why I ended up implementing OneSignal push adapter, not a good option tough since I use cloud code to push to thousands of installations and I don't know if parse server takes just to many seconds determining which installations should receive the push notification, so it still takes like 3-4min to push to 20k installations which is not a good option since I want to notiffy soccer matches goals and right now all of my "competence" apps are notifying faster than mine and I'm losing lots of users. If I push directly from OneSignal, the notification arrives in just a few seconds but I don't know how to tell OneSignal that I updated a record in my database other than using cloud code and the push adapter. If you find a better alternative please let me know
@flovilmart it's there any change for some hints about this adapter ... I would like to do it .. but don't know exactly where to start :( .. my applications have more than 1.000.000 devices with push notifications and I cannot send a push to all in seconds.
@mihai-iorga I believe the scheduling/batching of the push could be better handled. but that would require some changed on parse-server in order for the adapter to run the query, slice it in batches and schedule it properly
Fixes #9