search

parse-community / parse-server-push-adapter

A push notification adapter for Parse Server
https://parseplatform.org
MIT License
85 stars 100 forks source link

Bumps to alpha version of node-apn #105

Closed flovilmart closed 5 years ago

flovilmart commented 6 years ago
codecov[bot] commented 6 years ago

Codecov Report

Merging #105 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #105   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         258    258           
=====================================
  Hits          258    258
Impacted Files Coverage Δ
src/ParsePushAdapter.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7f9bc4...6506d28. Read the comment docs.

flovilmart commented 6 years ago

Did you test the setup instructions? I already published the package, can you let us know how it goes? I’ll deploy it after new year

funkenstrahlen commented 6 years ago

@flovilmart The setup instructions are only required if I want to use a custom version of the push adapter, correct?

I will check the installation instructions.

flovilmart commented 6 years ago

If you want to test this adapter at the 3.0.0-alpha1 version with your current parse server setup for example

funkenstrahlen commented 6 years ago

I checked the installation instructions. Works fine.

Because I am running my test backend on heroku I had to add this to my package.json: "@parse/push-adapter": "3.0.0-alpha1", instead of using npm directly to install the package.

funkenstrahlen commented 6 years ago

I do run 3.0.0-alpha1 on my test backend now. Works fine so far. However the ping bug that should be solved with apn 3.0.0-alpha1 never occurred on the test backend anyway because I have very few installations on this backend that can receive push notifications. So I can not really confirm if it is gone now.