Closed Schwobaland closed 7 years ago
@Schwobaland thanks for your contribution! It seems that the tests are failing. Can you take a look why?
Seems that apn 2.1.2 is not compatible with node 4.3. Tests are running with node 5. Parse-server has node 4.3 as minimum requirement. So - should i close this pull request? Or can minimum requirements be changed to node 5 or 6 (lts-version).
@Schwobaland we bumped the min version to 4.6, and now everything looks good on the tests.
Hi @Schwobaland, thanks for that Pull Request! We have a few things here and there before we can merge that one! Thanks again!
Hi @flovilmart, thanks for commenting. Fixed some of your requested changes. Please review this comment. I'm not sure, how to handle this, because of backward-compatibility.
I will be using two instances of parse-server: One for production and one for development. So for my use-cases this is not a problem, but...
@Schwobaland I'll have a look for multiple certs for a single topic, and I'll open a Pr on your branche before we get to merge that what do you think?
@flovilmart Sounds good! I'll wait for your PR π
I've been playing with apn 2.1.3, and thus far its been pretty unreliable unfortunately. the existing apn 1.x is more stable, but tracking doesn't work well.
@jeacott1 what do you mean by unstable?
http2 errors, and other sporadic exceptions. many have been mitigated by downgrading node to 5.11.1, but that causes other performance issues.
Anything worth reporting to the APN maintainer? Or related to the current implementation?
I think most of the issues are already documented either with apn, http2, or nodejs. eg: https://github.com/node-apn/node-apn/issues/449
@Schwobaland seems that it's getting updated to 2.1.3 last month, can you bump? I may takeover your branch as I'm in the midst of removing babel altogether from the package.
:exclamation: No coverage uploaded for pull request base (
master@6f382f1
). Click here to learn what that means. The diff coverage is100%
.
@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 5
Lines ? 249
Branches ? 0
=======================================
Hits ? 249
Misses ? 0
Partials ? 0
Impacted Files | Coverage Ξ | |
---|---|---|
src/index.js | 100% <ΓΈ> (ΓΈ) |
|
src/APNS.js | 100% <100%> (ΓΈ) |
|
src/GCM.js | 100% <100%> (ΓΈ) |
|
src/ParsePushAdapter.js | 100% <100%> (ΓΈ) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 6f382f1...f667715. Read the comment docs.
Closing as superset by #72 , thanks @Schwobaland for getting the ball rolling on that, one!
Update to apn. This enables parse to use http2-API from Apple. Tokens can be used instead of certificates. So one push-config enables to push to different apps.
There are some new options for configuring push-adapter:
Old property
bundleId
is mapped totopic
for backward-compatibility.