parse-community / parse-server-push-adapter

A push notification adapter for Parse Server
https://parseplatform.org
MIT License
87 stars 99 forks source link

if no deviceToken, count is never decremented fully, and the PushStatus never marked success/fail #54

Open jeacott1 opened 7 years ago

jeacott1 commented 7 years ago

if I have no deviceToken assigned, and send a push to that Installation, then in PushAdapterUtils.classifyInstallations:

// No deviceToken, ignore if (!installation.deviceToken) { continue; }

completely shortcuts any attempted execution of push to these devices.

this is fine, but because the push is never sent, no response from the push service can decrement the count, so it never completes, and PushStatus is left in a 'running' state with outstanding count equal to the number of null deviceToken records.

somewhere here, this needs to either drop the total count, or decrement the oustanding count, or just drop the if/continue altogether.