search

parse-community / parse-server-push-adapter

A push notification adapter for Parse Server
https://parseplatform.org
MIT License
88 stars 100 forks source link

Fixed error when sending pushes to one pushType #6

Closed leonluc-dev closed 8 years ago

leonluc-dev commented 8 years ago

Added check for empty devices sets when sending push notifications to senders. This fixes and issue where the empty sets being processed by the senders would throw several reference errors.

Fixes ParsePlatform/parse-server#1245

codecov-io commented 8 years ago

Current coverage is 87.02%

Merging #6 into master will increase coverage by +0.05% as of ffc916d

@@            master      #6   diff @@
======================================
  Files            5       5       
  Stmts          238     239     +1
  Branches        37      38     +1
  Methods          0       0       
======================================
+ Hit            207     208     +1
  Partial          1       1       
  Missed          30      30

Review entire Coverage Diff as of ffc916d

Powered by Codecov. Updated on successful CI builds.

flovilmart commented 8 years ago

One small nit otherwise LGTM

leonluc-dev commented 8 years ago

Tabs have been replaced with spaces (length =2). And the Array.isArray() check has been added