search

parse-community / parse-server-push-adapter

A push notification adapter for Parse Server
https://parseplatform.org
MIT License
85 stars 100 forks source link

APN with HTTP/2 #72

Closed flovilmart closed 7 years ago

flovilmart commented 7 years ago

@Schwobaland I just pushed here, rebased on master with extensive coverage. The only missing part is the retry on another connection upon failure.

codecov[bot] commented 7 years ago

Codecov Report

Merging #72 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #72   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         249    249           
=====================================
  Hits          249    249
Impacted Files Coverage Δ
src/APNS.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dfa75b5...0fefba7. Read the comment docs.

Schwobaland commented 7 years ago

@flovilmart looks good :) Shall I close #52? I think we don't need it anymore.

flovilmart commented 7 years ago

Yes! Thanks for your hard work! I also just added the retry mechanism, let me know what you think? (https://github.com/parse-server-modules/parse-server-push-adapter/pull/72/commits/fbe235b5e15a2d97dd95cf2c84eb925c577d19ce#diff-0388cf95ecca43f50bfebf698a4c0e3bR110)