parse-community / parse-server-s3-adapter

AWS S3 file storage adapter for Parse Server
Other
80 stars 83 forks source link

feat: Add option to generate pre-signed URL with expiration time #180

Closed andrewalc closed 1 year ago

andrewalc commented 1 year ago

Addresses:

PR branched off of:

Updated test with refactoring request that was mentioned here: https://github.com/parse-community/parse-server-s3-adapter/pull/117/files#r676915013

penchef commented 1 year ago

can't wait for it ! 😱

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 96.29% and project coverage change: -0.16 :warning:

Comparison is base (73b17e4) 95.72% compared to head (fadb515) 95.56%.

:exclamation: Current head fadb515 differs from pull request most recent head 807e51c. Consider uploading reports for the commit 807e51c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #180 +/- ## ========================================== - Coverage 95.72% 95.56% -0.16% ========================================== Files 2 2 Lines 187 203 +16 Branches 41 43 +2 ========================================== + Hits 179 194 +15 - Misses 8 9 +1 ``` | [Impacted Files](https://app.codecov.io/gh/parse-community/parse-server-s3-adapter/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community) | Coverage Δ | | |---|---|---| | [index.js](https://app.codecov.io/gh/parse-community/parse-server-s3-adapter/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-aW5kZXguanM=) | `95.08% <95.65%> (-0.38%)` | :arrow_down: | | [lib/optionsFromArguments.js](https://app.codecov.io/gh/parse-community/parse-server-s3-adapter/pull/180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-bGliL29wdGlvbnNGcm9tQXJndW1lbnRzLmpz) | `96.29% <100.00%> (+0.19%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

jimnor0xF commented 1 year ago

Wouldl love this!

parseplatformorg commented 1 year ago

🎉 This change has been released in version 2.1.0

dblythy commented 1 year ago

Nice work @danielsanfr and @andrewalc!