In afterSave, when creating a new object, dirty(:key) returns always 'false'

[Cloudtrackers]

New Issue Checklist

• [ ] I am not disclosing a vulnerability.
• [ ] I am not just asking a question.
• [ ] I have searched through existing issues.
• [ ] I can reproduce the issue with the latest version of Parse Server.

Issue Description

Server: 4.3.0 Database: Mongo 4.0,

Steps to reproduce

• Setup a beforeSave hook for some class
• Save an object to the same class
• look on the following sample

Parse.Cloud.afterSave("Profile", async (req) => { let token = { sessionToken: req.user.getSessionToken() }; console.log("-> ", req.original, req.object.dirty("isActive")); });

Actual Outcome

req.object.dirty("keyname"); always return false than actual result.

Expected Outcome

if the particular key attribute value is changed, 'req.object.dirty("keyname");' should be true else false.

Environment

Server: 4.3.0 Database: Mongo 4.0,

Server

• Parse Server version: 4.3.0
• Operating system: Mac OS
• Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): local

Database

• System (MongoDB or Postgres): MongoDB
• Database version: 4.0
• Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): local

Client

• SDK (iOS, Android, JavaScript, PHP, Unity, etc): JavaScript
• SDK version: 2.15.0

Logs

[dplewis]

I believe this is proper functionality. Saving an object clears dirty keys. If you want to check dirty keys try beforeSave.

[Cloudtrackers]

I believe this is proper functionality. Saving an object clears dirty keys. If you want to check dirty keys try beforeSave.

it's not working in afterSave hook. in afterSave, In the case of Updating the value, dirty keys always returns empty array.

[dplewis]

Can you write a failing test here. This will help us replicate your issue.

[Cloudtrackers]

Can you write a failing test here. This will help us replicate your issue.

Parse.Cloud.afterSave("Profile", async (req) => { let token = { sessionToken: req.user.getSessionToken() }; console.log(req.object.dirtyKeys()); });

just try this code in an sample code. dirtyKeys always returns empty array.

[mtrezza]

As @dplewis already pointed out, after saving an object, there are no dirty keys. A key is only dirty after its value has been modified and before its new value has been saved to the database.

1. object.set(key, "newValue"); --> object is dirty
2. object.save(); --> request to save new value to database
3. beforeSave trigger is called --> object is dirty
4. new value is saved to database
5. afterSave trigger is called --> object is not dirty

[mtrezza]

I'm closing this as it does not seem to be a Parse Server issue.

For help with Parse Server, here are some resources you can try:

• For code-level questions we recommend Stack Overflow using the parse-platform tag.
• For questions that are not appropriate for the above mentioned sites we recommend our community forum.

Feel free to comment if you have any questions and we can re-open this issue.