TypeScript typing issue with "FunctionRequest"

parse-community / parse-server

Parse Server for Node.js / Express

https://parseplatform.org

Apache License 2.0

20.82k stars 4.77k forks source link

TypeScript typing issue with "FunctionRequest" #7350

Closed nchambrier-iziwork closed 3 years ago

nchambrier-iziwork commented 3 years ago

New Issue Checklist

[x] I am not disclosing a vulnerability.
[x] I am not just asking a question.
[x] I have searched through existing issues.
- Related to #7334 and other typescript issues but more specific
[x] I can reproduce the issue with the latest version of Parse Server.

Issue Description

When I received a Cloud Function request, it's supposed to by typed as Parse.Cloud.FunctionRequest<T>, but this type is incorrect:

req.jobName is supposed to exist (declared in CustomRequest which FunctionRequest inherits, but this property exists only for Job requests)
req.functionName is not declared, but it definitely exists

Fix

Remove jobName and jobId (and probably others?) from CustomRequest and declare it in JobRequest only
Add functionName: string (and probably others?) in FunctionRequest

mtrezza commented 3 years ago

Thanks for reporting.

Are you using DefinitelyTyped type definitions?

nchambrier-iziwork commented 3 years ago

Looks like we haven't installed anything specific about Parse & Typing. Should I explicitely install @.***/parse-server" or similar?

Le ven. 16 avr. 2021 à 15:07, Manuel @.***> a écrit :

Thanks for reporting.

Are you using DefinitelyTyped type definitions?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/parse-community/parse-server/issues/7350#issuecomment-821161339, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATCWJMQW4UCZNE3KIJKERKDTJAZCTANCNFSM43BIEGAQ .

-- Nicolas Chambrier - RecOps

mtrezza commented 3 years ago

Depends on your setup. Parse TS definitions are currently manually maintained in DefinitelyTyped.

That would be

npm install --save-dev @types/parse

That also means, that any incorrect definition would have to be corrected in the repo there

TomWFox commented 3 years ago

As this is an issue with the DefinitelyTyped definitions, I’m going to close this one out.

chendoron commented 1 year ago

@TomWFox I'm confused why this is an issue with the DefinitelyTyped definitions, The type defs over there correspond to parse, not parse-server. parse-server has no type definitions at all.