refactor: Dry `handleAuthData` for safer code maintenance in the future

parse-community / parse-server

Parse Server for Node.js / Express

https://parseplatform.org

Apache License 2.0

20.87k stars 4.78k forks source link

refactor: Dry `handleAuthData` for safer code maintenance in the future #9025

Closed Moumouls closed 6 months ago

Moumouls commented 6 months ago

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Duplicated code related to an old GHSA on auth system. A quick dry refactor.

Closes: NONE

Approach

A small DRY refactor for easiest, safer futur code maintenance on auth.

Tasks

[x] Add tests
[x] Add changes to documentation (guides, repository pages, code comments)
[x] Add security check
[x] Add new Parse Error codes to Parse JS SDK

parse-github-assistant[bot] commented 6 months ago

I will reformat the title to use the proper commit message syntax.

parse-github-assistant[bot] commented 6 months ago

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.75%. Comparing base (2612a38) to head (1b492a9). Report is 141 commits behind head on alpha.

:exclamation: Current head 1b492a9 differs from pull request most recent head a5b97d0. Consider uploading reports for the commit a5b97d0 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## alpha #9025 +/- ## ========================================== - Coverage 94.31% 93.75% -0.57% ========================================== Files 186 186 Lines 14770 14676 -94 ========================================== - Hits 13931 13760 -171 - Misses 839 916 +77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

parseplatformorg commented 6 months ago

🎉 This change has been released in version 7.0.0-alpha.30

parseplatformorg commented 6 months ago

🎉 This change has been released in version 7.1.0-alpha.1

parseplatformorg commented 3 months ago

🎉 This change has been released in version 7.1.0-beta.1

parseplatformorg commented 3 months ago

🎉 This change has been released in version 7.1.0