feat: Ensure Database Password Security Check Covers All Possible URIs

pavan-dulam commented 2 months ago

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Closes: #8833

Approach

Addressed issue #8833 where the database password security check was not checking all possible URIs. Updated the CheckGroupDatabase class to handle cases where the database adapter is not defined in the configuration object, ensuring compatibility with configurations that use config.databaseURI instead. Added error handling with descriptive error messages for password security requirements. Updated issue tracker accordingly.

[x] Add tests
[ ] Add changes to documentation (guides, repository pages, code comments)
[ ] Add security check
[ ] Add new Parse Error codes to Parse JS SDK

parse-github-assistant[bot] commented 2 months ago

Thanks for opening this pull request!

pavan-dulam commented 2 months ago

Hi @mtrezza, Please review at your earliest convenience. Please let me know in case of any improvements. Thanks

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.75%. Comparing base (f1469c6) to head (187e440). Report is 8 commits behind head on alpha.

Files	Patch %	Lines
src/Security/CheckGroups/CheckGroupDatabase.js	50.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## alpha #9078 +/- ## ========================================== - Coverage 94.13% 93.75% -0.38% ========================================== Files 186 186 Lines 14687 14727 +40 ========================================== - Hits 13826 13808 -18 - Misses 861 919 +58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mtrezza commented 2 months ago

Please see CI and coverage report

parse-community / parse-server