fix: Saving object with a pointer field set to `undefined` throws error for Postgres

parse-community / parse-server

Parse Server for Node.js / Express

https://parseplatform.org

Apache License 2.0

20.69k stars 4.76k forks source link

fix: Saving object with a pointer field set to `undefined` throws error for Postgres #9147

Open andrewalc opened 3 weeks ago

andrewalc commented 3 weeks ago

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Closes: #9146

Approach

Work in progress, attempting to write a failing test case. Need to see if it fails for Postgres in CI (afaik i can only test on mongo locally. It passes for mongo but shouldn't for postgres)

Tasks

[ ] Add tests
[ ] Add changes to documentation (guides, repository pages, code comments)
[ ] Add security check
[ ] Add new Parse Error codes to Parse JS SDK

parse-github-assistant[bot] commented 3 weeks ago

I will reformat the title to use the proper commit message syntax.

parse-github-assistant[bot] commented 3 weeks ago

Thanks for opening this pull request!

mtrezza commented 3 weeks ago

Test passes for Postgres and MongoDB. Is this issue related to your custom code?

andrewalc commented 3 weeks ago

Test passes for Postgres and MongoDB. Is this issue related to your custom code?

I just found out how to test with postgres locally so I'm gonna try setting that up properly first. My issue might be because I didn't configure postgres for parse correctly.

mtrezza commented 3 weeks ago

@andrewalc sure, let us know how it goes, and whether the related issue can be closed.

andrewalc commented 3 weeks ago

@andrewalc sure, let us know how it goes, and whether the related issue can be closed.

posted an update in the issue here, might try again if i find some time but it seems like the case i have refuses to fail in this repo