Add support for async `FilesAdapter.getFileLocation` - Githubissues

parse-community / parse-server

Parse Server for Node.js / Express

https://parseplatform.org

Apache License 2.0

20.83k stars 4.77k forks source link

Add support for async `FilesAdapter.getFileLocation` #9268

Closed mtrezza closed 2 weeks ago

mtrezza commented 1 month ago

New Feature / Enhancement Checklist

Report security issues confidentially.
Any contribution is under this license.
Before posting search existing issues.

Current Limitation

The FilesAdapter protocol expects getFileLocation to be a synchronous method.

Feature / Enhancement Description

Add support for getFileLocation to be either an asynchronous or synchronous method:

Support for asynchronous is required for file adapters that generate the file URI asynchronously, for example the S3 file adapter using a pre-signed URL, see https://github.com/parse-community/parse-server-s3-adapter/issues/197.
Support for synchronous is required for backward compatibility.

Example Use Case

See https://github.com/parse-community/parse-server-s3-adapter/issues/197.

parse-github-assistant[bot] commented 1 month ago

Thanks for opening this issue!

🎉 We are excited about your ideas for improvement!

parseplatformorg commented 2 weeks ago

🎉 This change has been released in version 7.3.0-alpha.7