search

parse-server-modules / parse-server-onesignal-push-adapter

OneSignal push adapter for parse-server
MIT License
32 stars 28 forks source link

Support multiple OneSignal projects #17

Closed coolnalu closed 8 years ago

coolnalu commented 8 years ago

This PR proposes a way to support the following use case.

Parse service was able to support multiple push certificates in one project, so we could keep push certs for all of our apps in the same project and didn't need to specify which certs to use when we push to targeted users.

However, OneSignal only supports one dev and one prod certificates per apiId and apiKey pair. So on our self-hosted parse server, we need a way to select which key pairs to use when we send out push notifications.

Happy to discuss alternatives.

codecov-io commented 8 years ago

Current coverage is 73.59% (diff: 58.33%)

No coverage report found for master at 2c20a80.

Powered by Codecov. Last update 2c20a80...53bc466

flovilmart commented 8 years ago

@coolnalu we don't commit the lib folder (please revert that).

flovilmart commented 8 years ago

Also add tests for the support of that feature.

flovilmart commented 8 years ago

Closing that PR, please cleanup your commit history, revert all lib commits, the source is built upon pre-publish, that is run when publishing the module OR when running npm link.