search

parse-server-modules / parse-server-onesignal-push-adapter

OneSignal push adapter for parse-server
MIT License
32 stars 28 forks source link

broken on Parse-Server 2.3.3 #33

Closed jjdp closed 7 years ago

jjdp commented 7 years ago

caused by https://github.com/ParsePlatform/parse-server/pull/3080. deviceToken is not being sent

flovilmart commented 7 years ago

Can you provide more informations please? The changes on Parse-server were not supposed to affect adapters

jjdp commented 7 years ago

when i push in the cloud it returns a promise resolved to true but I noticed on my one signal dashboard a new user is added without a device. Before this would not create a new one, < v2.3.3. The device and platform will be empty, subscribed will be set to "no" and not like the picture shown

one signal

I can't reproduce again since I have downgraded back to 2.3.2 but I will be happy to help.

Im guessing the deviceToken is not being returned in post['include_android_reg_ids'].push(i['deviceToken']).

I do not know about IOS yet since I have only tested it on android.

jjdp commented 7 years ago

i forked the repo and updated some stuff to change it to sending the playerID instead of the deviceToken. the catch is that you have to get the playerID on the client using their provided SDKs, which is fine in my case of the project.

it's not 2.3.3's fault, something changed in one signal's REST api