search

parse-server-modules / parse-server-onesignal-push-adapter

OneSignal push adapter for parse-server
MIT License
32 stars 28 forks source link

Added generic background_data and android_background_data key. #9

Closed rob-64 closed 8 years ago

flovilmart commented 8 years ago

Can you add a test for both iOS background data options?

codecov-io commented 8 years ago

Current coverage is 78.57%

Merging #9 into master will increase coverage by +1.00%

  1. File ...SignalPushAdapter.js was modified. more
@@           master         #9   diff @@
========================================
  Files           1          1          
  Lines         107        112     +5   
  Methods         0          9     +9   
  Branches       17         18     +1   
========================================
+ Hits           83         88     +5   
  Misses         24         24          
  Partials        0          0

Powered by Codecov. Last updated by 2c20a80...15f153a

rob-64 commented 8 years ago

@flovilmart I have moved the 'background_data' test into its own, and the android and ios tests just use their respective keys.

rob-64 commented 8 years ago

@flovilmart are the new tests okay?

flovilmart commented 8 years ago

It seems to be ok, didn't get the time to go through it

MattiaConfalonieri commented 8 years ago

Sorry is this PR about my issue? https://github.com/parse-server-modules/parse-server-onesignal-push-adapter/issues/12