search

parse-server-modules / parse-server-sns-adapter

Parse Server SNS Adapter
18 stars 14 forks source link

Check if the data is null when get platform arn #8

Closed jun06t closed 7 years ago

jun06t commented 7 years ago

I sometimes get following error.

TypeError Cannot read property 'EndpointArn' of null 
    /usr/local/parse/node_modules/parse-server-sns-adapter/src/SNSPushAdapter.js:176:21 getPlatformArn
    /usr/local/parse/node_modules/parse-server-sns-adapter/node_modules/aws-sdk/lib/request.js:354:18 none
    /usr/local/parse/node_modules/parse-server-sns-adapter/node_modules/aws-sdk/lib/sequential_executor.js:105:20 callListeners
    /usr/local/parse/node_modules/parse-server-sns-adapter/node_modules/aws-sdk/lib/sequential_executor.js:77:10 emit
    /usr/local/parse/node_modules/parse-server-sns-adapter/node_modules/aws-sdk/lib/request.js:596:14 emit
    /usr/local/parse/node_modules/parse-server-sns-adapter/node_modules/aws-sdk/lib/request.js:21:10 transition
    /usr/local/parse/node_modules/parse-server-sns-adapter/node_modules/aws-sdk/lib/state_machine.js:14:12 runTo

to prevent this i fixed the code.

rogerhu commented 7 years ago

Do you happen to have a test you could add?

jun06t commented 7 years ago

i'm sorry. i've added a test.

rogerhu commented 7 years ago

Lgtm thanks