search

parseablehq / console

Frontend Client for Parseable. Parseable is a cloud native log storage and management for Kubernetes, containerised workloads
https://parseable.com
GNU Affero General Public License v3.0
22 stars 33 forks source link

fix prettier workflow git config #291

Closed balaji-jr closed 1 month ago

balaji-jr commented 1 month ago

Can you change the Checkout step to

      - name: Checkout
        uses: actions/checkout@v3

Don't think we need with. Refer: https://github.com/parseablehq/parseable/blob/main/.github/workflows/integration-test.yaml#L17-L18

Done. Removed the write permission to the prettier action.

nitisht commented 1 month ago

Write permission would be good for the action so it automatically fixes the issue right?

balaji-jr commented 1 month ago

Write permission would be good for the action so it automatically fixes the issue right?

I have added it again.

nitisht commented 1 month ago

so it needs the branch as well..guess will have to add the previous with section also. just need to see why it was failing