parsec-cloud / Parsec-Cloud-Preparation-Tool

Launch Parsec enabled cloud computers via your own cloud provider account.
925 stars 168 forks source link

Fix GoogleGRID url in Clear-Proxy.ps1 #20

Closed sjawhar closed 4 years ago

sjawhar commented 4 years ago

I found this while trying to debug why my EC2 instances launched from snapshots are always stuck at 1366x768 even though the machine the snapshots were created from works just fine. Didn't fix my problem, but maybe this will fix someone else's.

Two changes:

jamesstringerparsec commented 4 years ago

Thanks for your PR, this entire Clear-Proxy script needs a refactor, as it's mostly duplicate code of GPU updater tool + two entirely unrelated functions (removing the user set proxy and expanding the C partition automatically if the disk has been expanded).

These items are mostly there to protect users who don't have RDP access to fix accidentally doing something that breaks Parsec (like uninstalling their GPU or adding a proxy which prevents Parsec's connection). Now everyone has RDP access (because everyone who uses this self hosts their machine)...it makes less sense to even include Clear-Proxy.

GPU updater tool needs a refactor to accept a "-quiet $true" param, which will set it to run without user interaction and then clear-proxy can call that when required (AKA when the user deletes their GPU driver).

sjawhar commented 4 years ago

Makes sense. I've stopped trying to use this because of the issues I mentioned above and because I haven't been in places lately with fast enough internet to stream anyway :laughing: If you'd like, I can take a look again when I'm back in a land of decent bandwidth.

jamesstringerparsec commented 4 years ago

For now, I have removed the shortcut to this script from the desktop when you set up a new cloud machine. It's not essential to the function of the cloud machine and it will return when it's refactored.