Allow _guess_delimiter to work with a single row of data

parsecsv / parsecsv-for-php

CSV data parser for PHP.

MIT License

678 stars 176 forks source link

Allow _guess_delimiter to work with a single row of data #208

Closed gogowitsch closed 2 years ago

gogowitsch commented 2 years ago

Fix #206

gogowitsch commented 2 years ago

@jimeh Thanks for the review. Yeah, locally the tests run just fine.

Sadly, the Travis integration doesn't seem to work any longer. For this PR, it just says “Read-only mode”:

I suspect it has to do with the parsecsv organisation. Maybe you have to make me admin there?

jimeh commented 2 years ago

@Fonata I've made you an admin of the org. However, I couldn't find anything obvious myself to get travis-ci working again. The .org domain is deprecated, but on the .com there's no repos.

So I took the more extreme approach and converted the Travis-CI setup to GitHub Actions here: https://github.com/parsecsv/parsecsv-for-php/pull/209