parsing-science / pymc3_models

Apache License 2.0
158 stars 24 forks source link

models: naive bayes #4

Closed rlouf closed 5 years ago

rlouf commented 6 years ago

I am currently implementing Naive Bayes, and have a working version for the normal case (with predictions), but I am not sure how to graciously handle the multinomial and bernouilli cases. Scikit-learn wraps all 3 in different functions but somehow it does not feel right. I was thinking about checking the input values (float, int or binary) and choosing the more appropriate model, but I am not sure. Any idea?

parsing-science commented 6 years ago

I don't have much experience with Naive Bayes. If you have a particular dataset you're trying to fit, maybe just implement whichever version is relevant to you first. You can always go back and add the other versions later.